On 22.03.22 09:18, Pavel Pisa wrote:
Hello Marc,
thanks for positive reply for our years effort.
On Tuesday 22 of March 2022 08:46:22 Marc Kleine-Budde wrote:
On 22.03.2022 00:32:27, Pavel Pisa wrote:
This driver adds support for the CTU CAN FD open-source IP core.
The driver looks much better now. Good work. Please have a look at the
TX path of the mcp251xfd driver, especially the tx_stop_queue and
tx_wake_queue in mcp251xfd_start_xmit() and mcp251xfd_handle_tefif(). A
lockless implementation should work in your hardware, too.
Is this blocker for now? I would like to start with years tested base.
We have HW timestamping implemented for actual stable CTU CAN FD IP core
version, support for variable number of TX buffers which count can be
parameterized up to 8 in the prepared version and long term desire to
configurable-SW defined multi-queue which our HW interface allows to
dynamically server by á TX buffers. But plan is to keep combinations
of the design and driver compatible from the actual revision.
I would be happy if we can agree on some base/minimal support and get
it into mainline and use it as base for the followup patch series.
IMHO I would vote for this approach too.
There are many users of that open source IP CAN core right now and the
out-of-tree maintenance is no fun for all of them.
When the driver status is fine from the technical and programming style
standpoint we should move the improvements for the lockless
transmissions to a later date.
Best regards,
Oliver
I understand that I have sent code late for actual merge window,
but I am really loaded by teaching, related RISC-V simulator
https://github.com/cvut/qtrvsim , ESA and robotic projects
at company. So I would prefer to go step by step and cooperate
on updates and testing with my diploma students.
BTW: The PROP_SEG/PHASE_SEG1 issue is known:
+A curious reader will notice that the durations of the segments PROP_SEG
+and PHASE_SEG1 are not determined separately but rather combined and
+then, by default, the resulting TSEG1 is evenly divided between PROP_SEG
+and PHASE_SEG1.
and the flexcan IP core in CAN-FD mode has the same problem. When
working on the bit timing parameter, I'll plan to have separate
PROP_SEG/PHASE_SEG1 min/max in the kernel, so that the bit timing
algorithm can take care of this.
Hmm, when I have thought about that years ago I have not noticed real
difference when time quanta is move between PROP_SEG and PHASE_SEG1.
So for me it had no influence on the algorithm computation and
could be done on the chip level when minimal and maximal sum is
respected. But may it be I have overlooked something and there is
difference for CAN FD. May it be my colleagues Jiri Novak and
Ondrej Ille are more knowable.
As for the optimal timequantas per bit value, I agree that it
is not so simple. In the fact SJW and even tipple-sampling
should be defined in percentage of bit time and then all should
be optimized together and even combination with slight bitrate
error should be preferred against other exact matching when
there is significant difference in the other parameters values.
But I am not ready to dive into it till our ESA space NanoXplore
FPGA project passes final stage...
By the way we have received report from Andrew Dennison about
successful integration of CTU CAN FD into Litex based RISC-V
system. Tested with the Linux our Linux kernel driver.
The first iteration there, but he reported that some corrections
from his actual development needs to be added to the public
repo still to be usable out of the box
https://github.com/AndrewD/litecan
Best wishes,
Pavel Pisa
phone: +420 603531357
e-mail: pisa@xxxxxxxxxxxxxxxx
Department of Control Engineering FEE CVUT
Karlovo namesti 13, 121 35, Prague 2
university: http://dce.fel.cvut.cz/
personal: http://cmp.felk.cvut.cz/~pisa
projects: https://www.openhub.net/accounts/ppisa
CAN related:http://canbus.pages.fel.cvut.cz/
Open Technologies Research Education and Exchange Services
https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
