On 28.02.2022 10:05:03, Hangyu Hua wrote:
> I get it. But this means ems_usb_start_xmit have a redundant
> dev_kfree_skb beacause can_put_echo_skb delete original skb and
> can_free_echo_skb delete the cloned skb. While this code is harmless
> do you think we need to delete it ?
ACK. This dev_kfree_skb() should be deleted:
| err = usb_submit_urb(urb, GFP_ATOMIC);
| if (unlikely(err)) {
| can_free_echo_skb(netdev, context->echo_index, NULL);
|
| usb_unanchor_urb(urb);
| usb_free_coherent(dev->udev, size, buf, urb->transfer_dma);
| dev_kfree_skb(skb);
Can you create a patch?
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
