Re: [PATCH net-next 17/36] can: mcp251xfd: mcp251xfd_chip_sleep(): introduce function to bring chip into sleep mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23.02.2022 20:27:16, Jakub Kicinski wrote:
> On Wed, 23 Feb 2022 23:43:13 +0100 Marc Kleine-Budde wrote:
> > This patch adds a new function to bring the chip into sleep mode, and
> > replaces several occurrences of open coded variants.
> > 
> > Link: https://lore.kernel.org/all/20220207131047.282110-5-mkl@xxxxxxxxxxxxxx
> > Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> 
> Build is broken between patch 17 and patch 18 :(
> 
> drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c: In function ‘mcp251xfd_chip_stop’:
> drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c:644:1: error: no return statement in function returning non-void [-Werror=return-type]
>   644 | }
>       | ^
> 

Doh! Sorry for that, fixed and sent a new pull request:

https://lore.kernel.org/all/20220224082726.3000007-1-mkl@xxxxxxxxxxxxxx/

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux