Re: can: m_can: tcan4x5x m_can_isr do not handle tx if rx fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22.02.2022 17:41:54, Michael Anochin wrote:
> 
> > You're missing a "netif_wake_queue done" here. There's probably an
> > interrupt associated with this event. Add a print if that IRQ is active
> > right after reading the IRQ status register
> 
> Done, only on enter in m_can_isr "m_can_isr: ir=", not exit.
> 
> If there are a RX traffic on but, the latchup happens very quickly.

I just looked again at your overlay. Please change the IRQ type to
IRQ_TYPE_LEVEL_LOW. With edge falling you'll miss interrupts sooner or
later.

regards,
Marc

BTW: it's documented as level low in the bindings documentation:

|		interrupts = <14 IRQ_TYPE_LEVEL_LOW>;

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux