Acked-by: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
> out. Its stated that the functionality is not finally verified.
The subsequent call works, but I wasn't able to produce the bus errors,
so I could not verify that is actually worked.
And by now, I don't have access to the card, nor do I have a PCMCIA slot :-)
Kurt
On zo, 09 jan 2022 11:31:26 +0100, Marc Kleine-Budde wrote:
> In the function softing_startstop() the variable error_reporting is
> assigned but not used. The code that uses this variable is commented
> out. Its stated that the functionality is not finally verified.
>
> To fix the warning:
>
> | drivers/net/can/softing/softing_fw.c:424:9: error: variable 'error_reporting' set but not used [-Werror,-Wunused-but-set-variable]
> | int j, error_reporting;
>
> remove the comment, activate the code, but add a "0 &&" to the if
> expression and rely on the optimizer rather than the preprocessor to
> remove the code.
>
> Fixes: 03fd3cf5a179 ("can: add driver for Softing card")
> Cc: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> ---
> drivers/net/can/softing/softing_fw.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/can/softing/softing_fw.c b/drivers/net/can/softing/softing_fw.c
> index 7e1536877993..32286f861a19 100644
> --- a/drivers/net/can/softing/softing_fw.c
> +++ b/drivers/net/can/softing/softing_fw.c
> @@ -565,18 +565,19 @@ int softing_startstop(struct net_device *dev, int up)
> if (ret < 0)
> goto failed;
> }
> - /* enable_error_frame */
> - /*
> +
> + /* enable_error_frame
> + *
> * Error reporting is switched off at the moment since
> * the receiving of them is not yet 100% verified
> * This should be enabled sooner or later
> - *
> - if (error_reporting) {
> + */
> + if (0 && error_reporting) {
> ret = softing_fct_cmd(card, 51, "enable_error_frame");
> if (ret < 0)
> goto failed;
> }
> - */
> +
> /* initialize interface */
> iowrite16(1, &card->dpram[DPRAM_FCT_PARAM + 2]);
> iowrite16(1, &card->dpram[DPRAM_FCT_PARAM + 4]);
> --
> 2.34.1
>
>
