RE: [PATCH 1/2 v2] can: peak_usb: always ask for BERR reporting for PCAN-USB devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



​Hi,

- the rxerr/txerr counters were used for the first time to determine the new state from: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c11dcee758302702a83c6e85e4c4c3d9af42d2b3

- but their values could be read by the user space according to ctrl_mode, starting from: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ea8b33bde76c8fcef347b9b9cf15649fe41a5a6e

Which one do you think is the most appropriate?

Regards,

Stephane



            De: Marc Kleine-Budde
Envoyé: Vendredi 29 octobre 2021 14:53
À: Stéphane Grosjean
Cc: linux-can Mailing List
Objet: Re: [PATCH 1/2 v2] can: peak_usb: always ask for BERR reporting for PCAN-USB devices




On 21.10.2021 10:15:04, Stephane Grosjean wrote:

> Since for the PCAN-USB, the management of the transition to the

> ERROR_WARNING or ERROR_PASSIVE state is done according to the error

> counters, these must be requested unconditionally.

>

> Signed-off-by: Stephane Grosjean <s.grosjean@xxxxxxxxxxxxxxx>



This description indicates the patch should be backported, as it fixes a

problem. Can you figure out which patch added the problem in the first

place, so that we can add a Fixed tag?



regards,

Marc



--

Pengutronix e.K.                 | Marc Kleine-Budde           |

Embedded Linux                   | https://www.pengutronix.de  |

Vertretung West/Dortmund         | Phone: +49-231-2826-924     |

Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |


--
PEAK-System Technik GmbH
Sitz der Gesellschaft Darmstadt - HRB 9183
Geschaeftsfuehrung: Alexander Gach / Uwe Wilhelm
Unsere Datenschutzerklaerung mit wichtigen Hinweisen
zur Behandlung personenbezogener Daten finden Sie unter
www.peak-system.com/Datenschutz.483.0.html




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux