[PATCH] can: netlink: can_tdc_changelink(): assign tdc only after complete validation

[Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>]

Cc: Vincent MAILHOL <mailhol.vincent@xxxxxxxxxx>
Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
---
Feel free to squash into you series.

Marc

 drivers/net/can/dev/netlink.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/can/dev/netlink.c b/drivers/net/can/dev/netlink.c
index ba644f120573..f16a98998f45 100644
--- a/drivers/net/can/dev/netlink.c
+++ b/drivers/net/can/dev/netlink.c
@@ -109,7 +109,7 @@ static int can_tdc_changelink(struct net_device *dev, const struct nlattr *nla,
 {
 	struct nlattr *tb_tdc[IFLA_CAN_TDC_MAX + 1];
 	struct can_priv *priv = netdev_priv(dev);
-	struct can_tdc *tdc = &priv->tdc;
+	struct can_tdc tdc = { };
 	const struct can_tdc_const *tdc_const = priv->tdc_const;
 	int err;
 
@@ -130,7 +130,7 @@ static int can_tdc_changelink(struct net_device *dev, const struct nlattr *nla,
 		if (tdcv < tdc_const->tdcv_min || tdcv > tdc_const->tdcv_max)
 			return -EINVAL;
 
-		tdc->tdcv = tdcv;
+		tdc.tdcv = tdcv;
 	}
 
 	if (tb_tdc[IFLA_CAN_TDC_TDCO]) {
@@ -139,7 +139,7 @@ static int can_tdc_changelink(struct net_device *dev, const struct nlattr *nla,
 		if (tdco < tdc_const->tdco_min || tdco > tdc_const->tdco_max)
 			return -EINVAL;
 
-		tdc->tdco = tdco;
+		tdc.tdco = tdco;
 	}
 
 	if (tb_tdc[IFLA_CAN_TDC_TDCF]) {
@@ -148,9 +148,11 @@ static int can_tdc_changelink(struct net_device *dev, const struct nlattr *nla,
 		if (tdcf < tdc_const->tdcf_min || tdcf > tdc_const->tdcf_max)
 			return -EINVAL;
 
-		tdc->tdcf = tdcf;
+		tdc.tdcf = tdcf;
 	}
 
+	priv->tdc = tdc;
+
 	return 0;
 }
 
-- 
2.32.0