On 10.03.2021 22:56:21, Daniel Glöckner wrote: [...] > Or we leave can_rx_offload unchanged and keep two additional lists of skbs > inside the mcp251xfd driver: One for the packets that arrived before the > timestamp read from TBC and one for the packets that arrived later. At the > end of an iteration we call local_bh_disable, enqueue all packets from the > first list with can_rx_offload_queue_sorted, and the ask the softirq to > process them by calling local_bh_enable. Afterwards we move everything > from the second list to the first list and do the next iteration. In the patch series (which was started by Kurt Van Dijck) there is a second queue in rx-offload, this one is filled inside the IRQ handler and than added at the end of the IRQ handler to the queue that NAPI works on. He started this to get rid of the spin_lock operation on every skb added to the queue. > The drawback is that we can't use can_rx_offload_get_echo_skb. I'd like to keep it, as this optimizes other use cases, too. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
