Hi Marc, > Il 04/03/2021 16:42 Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> ha scritto: > > > Hello, > > this series picks up Dario Binacchi's patches and adds some cleanup > patches in front. > > The D_CAN controller supports up to 128 messages. Until now the driver > only managed 32 messages although Sitara processors and DRA7 SOC can > handle 64. > > The series was tested on a beaglebone board. > > Note: > I have not changed the type of tx_field (belonging to the c_can_priv > structure) to atomic64_t because I think the atomic_t type has size > of at least 32 bits on x86 and arm, which is enough to handle 64 > messages. > http://marc.info/?l=linux-can&m=139746476821294&w=2 reports the results > of tests performed just on x86 and arm architectures. > > Changes in v5: > - Add cleanup patches > - alloc_c_can_dev(): make use of struct_size() > > Changes in v4: > - Restore IF_RX interface. > - Add a comment to clarify why IF_RX interface is used instead of IF_TX. > - Use GENMASK() for setting msg_obj_rx_mask. > - Use BIT() for setting single bits and GENMASK() for setting masks. > > Changes in v3: > - Use unsigned int instead of int as type of the msg_obj_* fields > in the c_can_priv structure. > - Replace (u64)1 with 1UL in msg_obj_rx_mask setting. > - Use unsigned int instead of int as type of the msg_obj_num field > in c_can_driver_data and c_can_pci_data structures. > > Changes in v2: > - Fix compiling error reported by kernel test robot. > - Add Reported-by tag. > - Pass larger size to alloc_candev() routine to avoid an additional > memory allocation/deallocation. > - Add message objects number to PCI driver data. The "can: c_can: add support to 64 message objects" patch is missing from the series. Can I use version 4 or do you send it to me? Thanks and regards Dario
