Re: [RFC] can: isotp TX-path cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18.02.2021 22:54:32, Marc Kleine-Budde wrote:
> Hello
> 
> we've noticed that "candump -x" on normal CAN ISO-TP traffic shows:
> 
> | (2021-02-18 14:52:51.643904)  ca0  TX B E  713   [8]  20 0D 0E 0F AA AA AA AA
> 
> Note here the "B" and "E" flags are set. Another possibility is to use
> skb_put_zero() instead of skb_put(), but with a bigger overhead. A 3.
> option is to only memset() the non-data part of the struct canfd_frame.

Oliver, any opinion this?

I think I'll include this in my next pull request to net/master.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux