On 03.03.2021 13:07:50, Torin Cooper-Bennun wrote: > On Wed, Mar 03, 2021 at 01:55:23PM +0100, Marc Kleine-Budde wrote: > > > In peripherals, m_can_rx_handler is called with quota = 1 from an ISR > > > context. > > > > To be precise, it's a threaded Interrupt. Why not call the rx_handler > > with a reasonable quota instead? > > I see, thanks. Forgive my ignorance, but how long should a threaded ISR > reasonably block for? It's a IRQ thread, so it's subject to scheduling and priorities can be configured. The IRQ thread of the mcp251xfd driver runs until all IRQs are handled. > Was there ever a good reason for the quota to be 1 here? Don't know. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
