Hi Marc,
On Wed. 24 Feb 2021 at 04:49, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>
> On 24.02.2021 01:28:50, Vincent Mailhol wrote:
> [...]
> > --- a/drivers/net/can/dev/netlink.c
> > +++ b/drivers/net/can/dev/netlink.c
> > @@ -8,20 +8,18 @@
> > #include <net/rtnetlink.h>
> >
> > static const struct nla_policy can_policy[IFLA_CAN_MAX + 1] = {
> > - [IFLA_CAN_STATE] = { .type = NLA_U32 },
> > - [IFLA_CAN_CTRLMODE] = { .len = sizeof(struct can_ctrlmode) },
> > - [IFLA_CAN_RESTART_MS] = { .type = NLA_U32 },
> > - [IFLA_CAN_RESTART] = { .type = NLA_U32 },
> > - [IFLA_CAN_BITTIMING] = { .len = sizeof(struct can_bittiming) },
> > - [IFLA_CAN_BITTIMING_CONST]
> > - = { .len = sizeof(struct can_bittiming_const) },
> > - [IFLA_CAN_CLOCK] = { .len = sizeof(struct can_clock) },
> > - [IFLA_CAN_BERR_COUNTER] = { .len = sizeof(struct can_berr_counter) },
> > - [IFLA_CAN_DATA_BITTIMING]
> > - = { .len = sizeof(struct can_bittiming) },
> > - [IFLA_CAN_DATA_BITTIMING_CONST]
> > - = { .len = sizeof(struct can_bittiming_const) },
> > - [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
> > + [IFLA_CAN_STATE] = { .type = NLA_U32 },
> > + [IFLA_CAN_CTRLMODE] = { .len = sizeof(struct can_ctrlmode) },
> > + [IFLA_CAN_RESTART_MS] = { .type = NLA_U32 },
> > + [IFLA_CAN_RESTART] = { .type = NLA_U32 },
> > + [IFLA_CAN_BITTIMING] = { .len = sizeof(struct can_bittiming) },
> > + [IFLA_CAN_BITTIMING_CONST] = { .len = sizeof(struct can_bittiming_const) },
> > + [IFLA_CAN_CLOCK] = { .len = sizeof(struct can_clock) },
> > + [IFLA_CAN_BERR_COUNTER] = { .len = sizeof(struct can_berr_counter) },
> > + [IFLA_CAN_DATA_BITTIMING] = { .len = sizeof(struct can_bittiming) },
> > + [IFLA_CAN_DATA_BITTIMING_CONST] = { .len = sizeof(struct can_bittiming_const) },
> > + [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
> > + [IFLA_CAN_TERMINATION] = { .type = NLA_U16 },
>
> You doubled the last entry by mistake.
Arf...
As you noticed, the double entry is then removed in the next
patch. That is because I saw the issue but miserably modified the
wrong patch.
I will correct this in v2.
Yours sincerely,
Vincent
