On Mon. 25 Jan 2021 at 19:40, Oliver Hartkopp <socketcan@xxxxxxxxxxxx> wrote:
> The len8_dlc element is filled by the CAN interface driver and used for CAN
> frame creation by the CAN driver when the CAN_CTRLMODE_CC_LEN8_DLC flag is
> supported by the driver and enabled via netlink configuration interface.
>
> Add the command line support for cc-len8-dlc for Linux 5.11+
>
> Signed-off-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
> ---
> ip/iplink_can.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/ip/iplink_can.c b/ip/iplink_can.c
> index 735ab941..6a26f3ff 100644
> --- a/ip/iplink_can.c
> +++ b/ip/iplink_can.c
> @@ -35,10 +35,11 @@ static void print_usage(FILE *f)
> "\t[ one-shot { on | off } ]\n"
> "\t[ berr-reporting { on | off } ]\n"
> "\t[ fd { on | off } ]\n"
> "\t[ fd-non-iso { on | off } ]\n"
> "\t[ presume-ack { on | off } ]\n"
> + "\t[ cc-len8-dlc { on | off } ]\n"
> "\n"
> "\t[ restart-ms TIME-MS ]\n"
> "\t[ restart ]\n"
> "\n"
> "\t[ termination { 0..65535 } ]\n"
> @@ -101,10 +102,11 @@ static void print_ctrlmode(FILE *f, __u32 cm)
> _PF(CAN_CTRLMODE_ONE_SHOT, "ONE-SHOT");
> _PF(CAN_CTRLMODE_BERR_REPORTING, "BERR-REPORTING");
> _PF(CAN_CTRLMODE_FD, "FD");
> _PF(CAN_CTRLMODE_FD_NON_ISO, "FD-NON-ISO");
> _PF(CAN_CTRLMODE_PRESUME_ACK, "PRESUME-ACK");
> + _PF(CAN_CTRLMODE_CC_LEN8_DLC, "CC-LEN8-DLC");
> #undef _PF
> if (cm)
> print_hex(PRINT_ANY, NULL, "%x", cm);
> close_json_array(PRINT_ANY, "> ");
> }
> @@ -209,10 +211,14 @@ static int can_parse_opt(struct link_util *lu, int argc, char **argv,
> CAN_CTRLMODE_FD_NON_ISO);
> } else if (matches(*argv, "presume-ack") == 0) {
> NEXT_ARG();
> set_ctrlmode("presume-ack", *argv, &cm,
> CAN_CTRLMODE_PRESUME_ACK);
> + } else if (matches(*argv, "cc-len8-dlc") == 0) {
> + NEXT_ARG();
> + set_ctrlmode("cc-len8-dlc", *argv, &cm,
> + CAN_CTRLMODE_CC_LEN8_DLC);
> } else if (matches(*argv, "restart") == 0) {
> __u32 val = 1;
>
> addattr32(n, 1024, IFLA_CAN_RESTART, val);
> } else if (matches(*argv, "restart-ms") == 0) {
> --
> 2.29.2
Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
Reviewed and tested the patch, everything is OK for me.
Thanks Oliver!
