On Thu, Jan 21, 2021 at 05:33:40PM +0800, Su wrote: > The sizeof(u32) is hardcoded. IMO it's better to use the config value in > regmap. I got why you want to change this. Please update the patch description, comment on the increase of the object size and address the other issues I pointed out. I think it makes no sense to have the function mcp251xfd_get_val_bytes() as you have to use several regmaps anyways. > > > No functional effect. > > Not quite: > > > > scripts/bloat-o-meter shows: > > > > add/remove: 0/0 grow/shrink: 3/0 up/down: 104/0 (104) > > Function old new delta > > mcp251xfd_handle_tefif 980 1028 +48 > > mcp251xfd_irq 3716 3756 +40 > > mcp251xfd_handle_rxif_ring 964 980 +16 > > Total: Before=20832, After=20936, chg +0.50% Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
