On 11/20/20 12:23 PM, Oliver Hartkopp wrote: > > > On 20.11.20 11:38, Marc Kleine-Budde wrote: >> The firmware on the original USB2CAN by Geschwister Schneider Technologie >> Entwicklungs- und Vertriebs UG exchanges all data between the host and the >> device in host byte order. This is done with the struct >> gs_host_config::byte_order member, which is sent first to indicate the desired >> byte order. >> >> The widely used open source firmware candleLight doesn't support this feature >> and exchanges the data in little endian byte order. This breaks if a device >> with candleLight firmware is used on big endianess systems. > > Looks like this problem showed up pretty late. There are not that many BE users out there... > Won't it be better to implement the feature in the candlelight firmware > so that only the big endian users need to upgrade the candlelight > firmware instead of disabling this nice feature? It's easier to update the Linux driver, for LE Linux host systems this is basically a no-op. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: OpenPGP digital signature
