On 11/11/20 11:22 AM, Gerhard Uttenthaler wrote:
> Am 06.11.20 um 18:51 schrieb Marc Kleine-Budde:
>> On 11/6/20 6:01 PM, Gerhard Uttenthaler wrote:
>>> Signed-off-by: Gerhard Uttenthaler <uttenthaler@xxxxxxxxxxxxxxxx>
>>> ---
>>> drivers/net/can/usb/ems_usb.c | 141 +++++++++++++++++++++++++++++++++-
>>> 1 file changed, 139 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
>>> index 6a9ea6a4e687..d6b52b265536 100644
>>> --- a/drivers/net/can/usb/ems_usb.c
>>> +++ b/drivers/net/can/usb/ems_usb.c
>>> @@ -108,6 +108,17 @@ MODULE_LICENSE("GPL v2");
>>> */
>>> #define EMS_USB_ARM7_CLOCK 8000000
>>>
>>> +/* CPC-USB/FD supports the following CAN clocks
>>> + */
>>> +#define EMS_USB_FD_8MHZ 8000000
>> ^^^ one space only
> I can do that, no problem, but is it really better readable?
The rest of the driver seems to use one space, at least what I see from the
contect here.
>>> +#define EMS_USB_FD_16MHZ 16000000
>>> +#define EMS_USB_FD_20MHZ 20000000
>>> +#define EMS_USB_FD_24MHZ 24000000
>>> +#define EMS_USB_FD_32MHZ 32000000
>>> +#define EMS_USB_FD_40MHZ 40000000
>>> +#define EMS_USB_FD_80MHZ 80000000
>>
>> are these used?
> These frequencies are supported by the interface. I gave them as a
> reference only, if someone wants to compile it for a different clock.
> Used is:
> #define EMS_USB_FD_CLOCK EMS_USB_FD_40MHZ
Ok
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: OpenPGP digital signature
