Re: [PATCH v6 7/8] can-dev: introduce helpers to access Classical CAN DLC values

To: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, mailhol.vincent@xxxxxxxxxx
Subject: Re: [PATCH v6 7/8] can-dev: introduce helpers to access Classical CAN DLC values
From: Oliver Hartkopp <socketcan@xxxxxxxxxxxx>
Date: Tue, 10 Nov 2020 18:00:32 +0100
Cc: netdev@xxxxxxxxxxxxxxx
In-reply-to: <57350d3f-f8e7-ea2b-5071-be5b3347f631@pengutronix.de>
References: <20201110101852.1973-1-socketcan@hartkopp.net> <20201110101852.1973-8-socketcan@hartkopp.net> <57350d3f-f8e7-ea2b-5071-be5b3347f631@pengutronix.de>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0

On 10.11.20 16:50, Marc Kleine-Budde wrote:

On 11/10/20 11:18 AM, Oliver Hartkopp wrote:

I still think, that can_frame_set_cc_len() makes more sense. See my just posted
patches for illustration.


Yep. Your patches look fine!

Just remove my patches 7 & 8 and apply your suggestions instead.

Many thanks,
Oliver

References:
- [PATCH v6 0/8] Introduce optional DLC element for Classic CAN
  - From: Oliver Hartkopp
- [PATCH v6 7/8] can-dev: introduce helpers to access Classical CAN DLC values
  - From: Oliver Hartkopp
- Re: [PATCH v6 7/8] can-dev: introduce helpers to access Classical CAN DLC values
  - From: Marc Kleine-Budde