Re: [PATCH 00/17] Add support for CPC-USB/FD CAN FD interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/6/20 6:01 PM, Gerhard Uttenthaler wrote:
FTBFS:

> ems_usb.c: In function ‘ems_usb_rx_err’:
> ems_usb.c:574:20: error: expected ‘)’ before ‘__attribute__’
>   574 |     __attribute__((fallthrough));
>       |                    ^
>       |                    )
> ems_usb.c:574:32: error: expected statement before ‘)’ token
>   574 |     __attribute__((fallthrough));
>       |                                ^
> ems_usb.c:576:20: error: expected ‘)’ before ‘__attribute__’
>   576 |     __attribute__((fallthrough));
>       |                    ^
>       |                    )
> ems_usb.c:576:32: error: expected statement before ‘)’ token
>   576 |     __attribute__((fallthrough));
>       |                                ^

use "fallthrough;" instead.

please fix the following sparse warnings:

> ems_usb.c:533:66: warning: incorrect type in initializer (different base types)                                                                                                                  [14/7920]
> ems_usb.c:533:66:    expected unsigned int [usertype] psr                                                                                                                                                 
> ems_usb.c:533:66:    got restricted __le32 [usertype] psr                                                                                                                                                 
> ems_usb.c:534:37: warning: cast from restricted __le32                                                                                                                                                    
> ems_usb.c:535:72: warning: restricted __le32 degrades to integer                                                                                                                                          
> ems_usb.c:805:29: warning: invalid assignment: |=                                                                                                                                                         
> ems_usb.c:805:29:    left side has type restricted __le32                                                                                                                                                 
> ems_usb.c:805:29:    right side has type int                                                                                                                                                              
> ems_usb.c:807:29: warning: invalid assignment: &=                                                                                                                                                         
> ems_usb.c:807:29:    left side has type restricted __le32                                                                                                                                                 
> ems_usb.c:807:29:    right side has type int                                                                                                                                                              
> ems_usb.c:810:37: warning: invalid assignment: |=                                                                                                                                                         
> ems_usb.c:810:37:    left side has type restricted __le32                                                                                                                                                 
> ems_usb.c:810:37:    right side has type int                                                                                                                                                              
> ems_usb.c:812:37: warning: invalid assignment: &=
> ems_usb.c:812:37:    left side has type restricted __le32
> ems_usb.c:812:37:    right side has type int
> ems_usb.c:815:37: warning: invalid assignment: |=
> ems_usb.c:815:37:    left side has type restricted __le32
> ems_usb.c:815:37:    right side has type int
> ems_usb.c:817:37: warning: invalid assignment: &=
> ems_usb.c:817:37:    left side has type restricted __le32
> ems_usb.c:817:37:    right side has type int
> ems_usb.c:1321:22: warning: incorrect type in assignment (different base types)
> ems_usb.c:1321:22:    expected restricted __le32 [usertype] can_clk
> ems_usb.c:1321:22:    got unsigned int [usertype] freq
> ems_usb.c:1323:22: warning: incorrect type in assignment (different base types)
> ems_usb.c:1323:22:    expected restricted __le16 [usertype] tseg1
> ems_usb.c:1323:22:    got unsigned int
> ems_usb.c:1324:22: warning: incorrect type in assignment (different base types)
> ems_usb.c:1324:22:    expected restricted __le16 [usertype] tseg2
> ems_usb.c:1324:22:    got unsigned int [usertype] phase_seg2
> ems_usb.c:1325:20: warning: incorrect type in assignment (different base types)
> ems_usb.c:1325:20:    expected restricted __le16 [usertype] brp
> ems_usb.c:1325:20:    got unsigned int [usertype] brp
> ems_usb.c:1326:20: warning: incorrect type in assignment (different base types)
> ems_usb.c:1326:20:    expected restricted __le16 [usertype] sjw
> ems_usb.c:1326:20:    got unsigned int [usertype] sjw
> ems_usb.c:1335:24: warning: restricted __le32 degrades to integer
> ems_usb.c:1353:29: warning: invalid assignment: |=
> ems_usb.c:1353:29:    left side has type restricted __le32
> ems_usb.c:1353:29:    right side has type int
> ems_usb.c:1355:37: warning: invalid assignment: |=
> ems_usb.c:1355:37:    left side has type restricted __le32
> ems_usb.c:1355:37:    right side has type int
> ems_usb.c:1361:22: warning: incorrect type in assignment (different base types)
> ems_usb.c:1361:22:    expected restricted __le16 [usertype] tseg1
> ems_usb.c:1361:22:    got unsigned int
> ems_usb.c:1362:22: warning: incorrect type in assignment (different base types)
> ems_usb.c:1362:22:    expected restricted __le16 [usertype] tseg2
> ems_usb.c:1362:22:    got unsigned int [usertype] phase_seg2
> ems_usb.c:1363:20: warning: incorrect type in assignment (different base types)
> ems_usb.c:1363:20:    expected restricted __le16 [usertype] brp
> ems_usb.c:1363:20:    got unsigned int [usertype] brp
> ems_usb.c:1364:20: warning: incorrect type in assignment (different base types)
> ems_usb.c:1364:20:    expected restricted __le16 [usertype] sjw
> ems_usb.c:1364:20:    got unsigned int [usertype] sjw
> ems_usb.c:1373:24: warning: restricted __le32 degrades to integer
> ems_usb.c:1428:21: warning: incorrect type in assignment (different base types)
> ems_usb.c:1428:21:    expected restricted __le32 [usertype] config
> ems_usb.c:1428:21:    got int
> ems_usb.c:1429:22: warning: incorrect type in assignment (different base types)
> ems_usb.c:1429:22:    expected restricted __le32 [usertype] can_clk
> ems_usb.c:1429:22:    got int
> ems_usb.c:1455:38: warning: restricted __le16 degrades to integer
> ems_usb.c:1455:38: warning: restricted __le16 degrades to integer

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux