On 02.11.20 04:58, Oliver Hartkopp wrote:
> On 01.11.20 17:12, Oliver Hartkopp wrote:
>
>> Yes. After you shared your thoughts I would indeed tend to provide an
>> option '-8' and then always print the raw DLC in parenthesis e.g. (0) or
>> (F).
>>
>> IMO this len8_dlc stuff is an expert feature that normal users do not
>> care about. Therefore it should be disabled by default.
OK, it is a reasonable compromise.
> I implemented '-8' for your testing with curly braces {} which just
> looks 'more unusual' than ().
>
> Please give it a try also from a visual standpoint if it fits for you.
I did the test. As usual, it works fine.
Is the use of the hexadecimal notation a deliberate choice? I
initially did that because it is the easiest hack. I was expecting to
use a decimal representation in the finalized version but the
hexadecimal notation stands out even more and seems like a good
choice.
With both the curly braces and the hexadecimal representation, I do
not see how we could do something more visual.
Concerning the () vs. {}, honestly, that's a coin flip for me. No
preferences, both are fine.
Also, when receiving both Classical and FD frames, until now, the only
visual clue was the presence of the zero prefix: [x] for Classical
vs. [0x] for FD. I think that I might use the -8 option even when not
using CAN_CTRLMODE_CC_LEN8_DLC. Like that, the Classical frames would
show as {x} and the FD frames as [0x]: a way more visual clue than the
current one.
I will continue to think of other use cases for the other can-utils
programs.
Yours sincerely,
Vincent Mailhol
