On 10/27/20 7:18 PM, Patrick Menschel wrote: > >>> It is different but I'm having trouble understanding why it works and >>> the new overlay for the newer driver does not. >> >> Have you actually tested the waveshare driver and overlay with your setup? >> >> If you have a scope or logic analyser attach it to SPI bus (MISO, MOSI, Clock, >> Chipselect and the IRQ Line of the Chip) and check what's going on there. >> >> Marc >> > > Is the target path for clocks correct? > > I mean "/clocks" It doesn't matter where you put them... > https://gist.github.com/pdp7/784d0ba8b9648d20ab055747ec945225#file-2xmcp2517fd-overlay-dts-L49 > > instead of "/" > > https://github.com/marckleinebudde/linux/blob/v5.4-rpi/mcp251xfd-20201022-54/arch/arm/boot/dts/overlays/mcp251xfd-spi0-0-overlay.dts#L38 The mcp251xfd node references them via the label ("<&can_osc>"): https://github.com/marckleinebudde/linux/blob/v5.4-rpi/mcp251xfd-20201022-54/arch/arm/boot/dts/overlays/mcp251xfd-spi0-0-overlay.dts#L61 The driver will bail out even earlier if no clock is found: https://github.com/marckleinebudde/linux/blob/v5.4-rpi/mcp251xfd-20201022-54/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c#L2764 regards Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: OpenPGP digital signature
