On 10/26/20 10:50 AM, Thomas.Kopp@xxxxxxxxxxxxx wrote: > This patch series works fine on my setup (RPI4, MCP2518FD, external 4 MHz > crystal). \o/ Thanks \o/ > Going through the code I noticed that the Min specified OSC frequency is > specified from 1 MHz to 40 MHz. Technically the DS only specifies 4,20 and > 40MHz as crystal/resonator options and 2MHz input as the minimum external > clock. 4 with PLL and 40 direct are the preferred options for CAN-FD. I think > the code is fine, given that the default is 40 MHz and it's the user's > responsibility to design in the part according to the DS. We could narrow > down the pll clockcheck to only allow 4 MHz though. I'll address this in my next patch series. > All 3 patches in this series: > Tested-by: Thomas Kopp <thomas.kopp@xxxxxxxxxxxxx> regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: OpenPGP digital signature
