[PATCH V4] can: flexcan: disable wakeup in flexcan_remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



With below sequence, we can see wakeup default is enabled after re-load
module, so need disable wakeup in flexcan_remove().

root@imx8qmevk:~# lsmod
Module                  Size  Used by
crct10dif_ce           16384  1
flexcan                32768  0
can_dev                36864  1 flexcan
root@imx8qmevk:~# cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup
disabled
root@imx8qmevk:~# echo enabled > /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup
root@imx8qmevk:~# cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup
enabled
root@imx8qmevk:~# rmmod flexcan
root@imx8qmevk:~# rmmod can_dev
root@imx8qmevk:~# modprobe flexcan
[  147.877689] CAN device driver interface
root@imx8qmevk:~# cat /sys/bus/platform/drivers/flexcan/5a8e0000.can/power/wakeup
enabled

Fixes: de3578c198c6 ("can: flexcan: add self wakeup support")
Fixes: 915f9666421c ("can: flexcan: add support for DT property 'wakeup-source'")
Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
---
 drivers/net/can/flexcan.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 06f94b6f0ebe..881799bd9c5e 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
@@ -2062,6 +2062,8 @@ static int flexcan_remove(struct platform_device *pdev)
 {
 	struct net_device *dev = platform_get_drvdata(pdev);
 
+	device_set_wakeup_enable(&pdev->dev, false);
+	device_set_wakeup_capable(&pdev->dev, false);
 	unregister_flexcandev(dev);
 	pm_runtime_disable(&pdev->dev);
 	free_candev(dev);
-- 
2.17.1




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux