On 10/14/20 10:53 AM, Joakim Zhang wrote: >> Since commit: >> >> 048e3a34a2e7 can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for >> stop mode acknowledgment >> >> the driver polls the IP core's internal bit MCR[LPM_ACK] as stop mode >> acknowledge and not the acknowledgment on chip level. >> >> This means the 4th and 5th value of the property "fsl,stop-mode" isn't used >> anymore. This patch removes the used "ack_gpr" and "ack_bit" from the >> driver. >> >> Link: >> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flore.kern >> el.org%2Fr%2F20201006203748.1750156-15-mkl%40pengutronix.de&dat >> a=02%7C01%7Cqiangqing.zhang%40nxp.com%7C1540ad5bf7bd4a1e10a508d8 >> 6b087a67%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637377031 >> 436785787&sdata=ierIIVdSqZFLklIvgMokHX6LU77cEWQgUGzUi6CHdDI% >> 3D&reserved=0 >> Fixes: 048e3a34a2e7 ("can: flexcan: poll MCR_LPM_ACK instead of GPR ACK >> for stop mode acknowledgment") >> Cc: Joakim Zhang <qiangqing.zhang@xxxxxxx> >> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > > [...] >> /* stop mode property format is: >> - * <&gpr req_gpr req_bit ack_gpr ack_bit>. >> + * <&gpr req_gpr>. > > Hi Marc, > > Sorry for response delay, stop mode property format should be "<&gpr req_gpr > req_bit>", I saw this code change has went into linux-next, so I will correct > it by the way next time when I upsteam wakeup function for i.MX8. Doh! I wrongly deleted "req_bit" in the comment, but the code should be all right. I'll add that back. > Need I update stop mode property in dts file? Although this function won't be > broken without dts update. Yes, you can send patches to update the dts (after net-next was merged to linus). Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: OpenPGP digital signature
