> -----Original Message----- > From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > Sent: 2020年9月25日 17:03 > To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; linux-can@xxxxxxxxxxxxxxx > Cc: dl-linux-imx <linux-imx@xxxxxxx>; netdev@xxxxxxxxxxxxxxx > Subject: Re: [PATCH linux-can-next/flexcan 1/4] can: flexcan: initialize all flexcan > memory for ECC function > > On 9/25/20 10:51 AM, Joakim Zhang wrote: > >>> I notice it just now, seems lack of patch for imx firmware in > >>> upstream, that will always export scu symbols. > >>> include/linux/firmware/imx/svc/misc.h > >> > >> That will affect "can: flexcan: add CAN wakeup function for i.MX8" > >> not this patch, right? > > > > Yes, only affect "can: flexcan: add CAN wakeup function for i.MX8", I > > will remove this patch first. > > ok > > > Sorry, I replied in a wrong place. > > np > > > "can: flexcan: initialize all flexcan memory for ECC function" for > > this patch, I find this issue in i.MX8MP, which is the first SoC > > implements ECC for i.MX > > What about the mx7? > > > I think this patch should compatible with others which has ECC > > support, but I don't have one to have a test. > > What about the mx7? As I know only i.MX7D integrated in Flexcan without ECC, I am not quite understand what you meaning. Could you explain more? Best Regards, Joakim Zhang > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | https://www.pengutronix.de | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |