Re: [PATCH] can: mcp25xxfd: mcp25xxfd_irq(): add missing initialization of variable set_normal mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 23 September 2020 5:17:26 PM IST, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>This patch fixes the following warning:
>
>    drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c:2155 mcp25xxfd_irq()
>    error: uninitialized symbol 'set_normal_mode'.
>
>by adding the missing initialization.
>
>Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>

Thanks, 
Mani

>---
> drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c
>b/drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c
>index bd2ba981ae36..912a73458a41 100644
>--- a/drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c
>+++ b/drivers/net/can/spi/mcp25xxfd/mcp25xxfd-core.c
>@@ -2073,7 +2073,7 @@ static irqreturn_t mcp25xxfd_irq(int irq, void
>*dev_id)
> 
> 	do {
> 		u32 intf_pending, intf_pending_clearable;
>-		bool set_normal_mode;
>+		bool set_normal_mode = false;
> 
> 		err = regmap_bulk_read(priv->map_reg, MCP25XXFD_REG_INT,
> 				       &priv->regs_status,

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux