On 2/11/20 1:04 PM, Thomas Kopp wrote: > I started testing your driver yeay! > at > https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/log/drivers/net/can/spi/mcp25xxfd?h=v5.4/mcp25xxfd For testing use the lastest 5.4/mcp25xxfd-YYYYMMDD-X, they will not be rebased. > and noticed two small things in the register definitions. tnx, applied > Overall TX seems to be working fine - one thing I noticed when > testing with cangen can0 -b -g 0 and another external node ^^ I've not tested CAN-FD, yet. > periodically sending frames on the bus (with 2ms gaps) I'm eventually > getting stuffing errors from which the driver never really recovers. Con you describe the complete setup? - which mcp25xxfd? - exact "ip" command line to configure the mcp - exact command line on the mcp - which controller on the other side - command line on the other side to generate frames > As soon as the external node then stops sending messages, the > MCP2518FD node stops sending as well and gets unresponsive (ssh isn't > possible anymore etc.). Do you see anything in the kernel logs? > When resuming the external CAN traffic the node becomes responsive > again. The driver was compiled with Additional Debugging output and > Logging enabled. Ifconfig doesn't show any RX/TX errors and shows > plausible numbers for packets transmitted/received. Am I chasing > ghosts here or have you encountered similar behaviour? With two mcp2518fd on the same machine connected to each other, CAN-2.0 mode, but no third station and a specific test I see errors as well. The controller finally not sending anymore, however the system keeps responsive. I've to debug this further. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
