On di, 21 jan 2020 21:03:42 +0100, Oliver Hartkopp wrote: > Hi Kurt, ... > > Yes. That's really weird as is just has an impact on the socket API. But it > should not have any impact on the CAN_RAW socket they are using. > > Hm - in fact is has an impact on the socket API. > Before the patch the user space was able to send 16 bytes to the CAN_RAW > socket. Now it's only 8 byte as you reduced the required size. Nack, the CAN_REQUIRED_SIZE is applied on struct sockaddr_can only, to guard against breaking ABI with the upcoming addition of j1939 fields. But where in the past, the tp members where necessary but unused, they are now optional and still unused, in both raw_bind and raw_sendmsg. But this does not propagate to sk_buff, so I could not find how it changes anything that worked before into a crash. > > Regards, > Oliver >
