Re: [PATCH 10/10] can: c_can: configurable amount of D_CAN RX objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/17/19 1:16 PM, Kurt Van Dijck wrote:
> From: Andrejs Cainikovs <Andrejs.Cainikovs@xxxxxxxxxxxxx>
> 
> Make number of D_CAN RX message objects configurable. This will allow
> having bigger (or smaller) RX buffer instead of 50/50 split for RX/TX.

You want to avoid large HW queues due to buffer bloat, so make the
number of TX mailboxes a reasonable default. e.g. 4 or 8.

> Signed-off-by: Andrejs Cainikovs <andrejs.cainikovs@xxxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Signed-off-by: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
> ---

NACK, no Kconfig option, please make the number of RX/TX mailboxes
dependent on the DT compatible.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux