Hi Sean, Have you found time to test this patch set? Thanks :-) Best Regards, Joakim Zhang > -----Original Message----- > From: Joakim Zhang <qiangqing.zhang@xxxxxxx> > Sent: 2019年12月10日 17:00 > To: mkl@xxxxxxxxxxxxxx; sean@xxxxxxxxxx; linux-can@xxxxxxxxxxxxxxx > Cc: dl-linux-imx <linux-imx@xxxxxxx>; netdev@xxxxxxxxxxxxxxx; Joakim Zhang > <qiangqing.zhang@xxxxxxx> > Subject: [PATCH V2 1/2] can: flexcan: disable runtime PM if register flexcandev > failed > > Had better disable runtime PM if register flexcandev failed. > > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx> > ------ > ChangeLog: > V1->V2: *no change. > --- > drivers/net/can/flexcan.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index > 3a754355ebe6..6c1ccf9f6c08 100644 > --- a/drivers/net/can/flexcan.c > +++ b/drivers/net/can/flexcan.c > @@ -1681,6 +1681,8 @@ static int flexcan_probe(struct platform_device > *pdev) > return 0; > > failed_register: > + pm_runtime_put_noidle(&pdev->dev); > + pm_runtime_disable(&pdev->dev); > free_candev(dev); > return err; > } > -- > 2.17.1