Re: [PATCH v6 2/2] can: m_can: remove double clearing of clock stop request bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Skip this one :)

On 11/12/2019 14.53, Sean Nyekjaer wrote:
The CSR bit is already cleared when arriving here so remove this section of
duplicate code.
The registers set in m_can_config_endisable() is set to same exact
values as before this patch.

Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
Acked-by: Sriram Dash <sriram.dash@xxxxxxxxxxx>
Acked-by: Dan Murphy <dmurphy@xxxxxx>
---
Changes since v3:
  - Fixed fixes tag

Changes since v4:
  - None

Changes since v5:
  - None

  drivers/net/can/m_can/m_can.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 02c5795b7393..4edc6f6e5165 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -380,10 +380,6 @@ void m_can_config_endisable(struct m_can_classdev *cdev, bool enable)
  		cccr &= ~CCCR_CSR;
if (enable) {
-		/* Clear the Clock stop request if it was set */
-		if (cccr & CCCR_CSR)
-			cccr &= ~CCCR_CSR;
-
  		/* enable m_can configuration */
  		m_can_write(cdev, M_CAN_CCCR, cccr | CCCR_INIT);
  		udelay(5);




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux