Re: [PATCH v3] can: m_can: remove double clearing of clock stop request bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sean

On 12/9/19 2:32 PM, Dan Murphy wrote:
Sean

On 12/9/19 2:15 PM, Sean Nyekjaer wrote:
Removal of duplicate code

Signed-off-by: Sean Nyekjaer <sean@xxxxxxxxxx>
Acked-by: Sriram Dash <sriram.dash@xxxxxxxxxxx>
---
Changes since v2:
  - Changed commit msg not to confuse :)

  drivers/net/can/m_can/m_can.c | 4 ----
  1 file changed, 4 deletions(-)

diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 02c5795b7393..4edc6f6e5165 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -380,10 +380,6 @@ void m_can_config_endisable(struct m_can_classdev *cdev, bool enable)
          cccr &= ~CCCR_CSR;
        if (enable) {
-        /* Clear the Clock stop request if it was set */
-        if (cccr & CCCR_CSR)
-            cccr &= ~CCCR_CSR;
-
          /* enable m_can configuration */
          m_can_write(cdev, M_CAN_CCCR, cccr | CCCR_INIT);
          udelay(5);

I am checking with the HW guys to make sure we are removing the correct CSR clearing.  I don't know if we need to clear the CSR when disabling the m_can configuration access or if we need to clear it for both enabling and disabling when the CSR is set to 1.

Dan


Its all good!

Acked-by: Dan Murphy <dmurphy@xxxxxx>




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux