On 06/12/2019 13.41, Sean Nyekjaer wrote:
Hi Dan,
3. Questions or comments :)
All tests have been run with "net: m_can: Make wake-up gpio an optional"
applied.
1.
From Documentation/devicetree/bindings/net/can/tcan4x5x.txt
reset-gpios = <&gpio1 27 GPIO_ACTIVE_LOW>;
The reset gpio is ACTIVE_HIGH works if changed to this in my device-tree.
I could do the patch for this if desired :)
2.
From Documentation/devicetree/bindings/net/can/tcan4x5x.txt
- device-state-gpios: Input GPIO that indicates if the device is in
a sleep state or if the device is active.
What pin is that exactly on the tcan4550 chip? I can't find a pin that
is matches this functionality.
3.
When my board is booted, the reset line to the tcan4x5x is high.
At 1. probe it's failing because it can't talk to the tcan device. We
are not waiting the required 700 μs described in the datasheet.
root@iwg26:/data/root# insmod tcan4x5x.ko
[ 148.764733] tcan4x5x spi2.0: no clock found
[ 148.768989] tcan4x5x spi2.0: no CAN clock source defined
[ 148.807644] tcan4x5x spi2.0: Unsupported version number: 0
[ 148.814117] tcan4x5x spi2.0: Probe failed, err=-22
[ 148.829416] tcan4x5x: probe of spi2.0 failed with error -22
Second probe
root@iwg26:/data/root# rmmod tcan4x5x; insmod tcan4x5x.ko
[ 180.351252] tcan4x5x spi2.0: no clock found
[ 180.355506] tcan4x5x spi2.0: no CAN clock source defined
[ 180.395946] tcan4x5x spi2.0 (unnamed net_device) (uninitialized):
Failed to init module
[ 180.655459] tcan4x5x spi2.0: m_can device registered (irq=84,
version=32)
[ 180.662629] tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized.
Third probe (everthing seems fine)
root@iwg26:/data/root# rmmod tcan4x5x; insmod tcan4x5x.ko
[ 208.240726] tcan4x5x spi2.0: no clock found
[ 208.244980] tcan4x5x spi2.0: no CAN clock source defined
[ 208.542998] tcan4x5x spi2.0: m_can device registered (irq=84,
version=32)
[ 208.550140] tcan4x5x spi2.0 can2: TCAN4X5X successfully initialized.
I will try with a usleep >700us to fix this :)
A usleep_range(700, 1000); right after the reset pin is put low will fix
the non talking device "Unsupported version number: 0".
But i still have this on first probe, gone on second:
tcan4x5x spi2.0 (unnamed net_device) (uninitialized):
Failed to init module
/Sean
