> -----Original Message----- > From: Sean Nyekjaer <sean@xxxxxxxxxx> > Sent: 2019年12月5日 19:12 > To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; Marc Kleine-Budde > <mkl@xxxxxxxxxxxxxx>; linux-can@xxxxxxxxxxxxxxx > Cc: dl-linux-imx <linux-imx@xxxxxxx>; netdev@xxxxxxxxxxxxxxx > Subject: Re: [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe > stage > > > > On 05/12/2019 12.04, Joakim Zhang wrote: > > Hi Sean, > > > > At my side, both Power-On-Reset and reboot from console can get CAN-IP out > of stop mode, HW is i.MX7D-SDB/i.MX8QXP-mek. > > I think HW design could make difference. > > > > We more care about how does CAN-IP stuck in stop mode, could you please > explain in details? We want figure out the root cause. > > When running only with the first stop mode commit: > de3578c198c6 ("can: flexcan: add self wakeup support") And there is incoming > traffic on both CAN lines. > I happens when going into suspend. > Then the CAN-IP is stuck in stop mode.. That means with below patch then CAN-IP could not been stuck in stop mode, right? can: flexcan: fix deadlock when using self wakeup If yes, I think we don't need check stop mode in probe stage, since issue has disappeared automatically. > I'm on this custom i.MX6ull board. > I have another custom board also with the i.MX6ull where the watchdog pins > are wired to the PMIC. > Will try to test on that next week Okay, thanks. Best Regards, Joakim Zhang > /Sean