> -----Original Message----- > From: Sean Nyekjaer <sean@xxxxxxxxxx> > Sent: 2019年11月15日 16:54 > To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; mkl@xxxxxxxxxxxxxx; > linux-can@xxxxxxxxxxxxxxx > Cc: dl-linux-imx <linux-imx@xxxxxxx>; netdev@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/3] can: flexcan: fix deadlock when using self wakeup > > > > On 15/11/2019 06.09, Joakim Zhang wrote: > > > > Hi Sean, > > > > I remember that you are the first one sending out the patch to fix this issue, > and I NACK the patch before. > > I am so sorry for that, it can work fine after testing at my side. > > Could you help double check at your side for this patch? Both wakeup from > totally suspend and wakeup from suspending? > > > > With this patch, we can fix two problems: > > 1) fix deadlock when using self wakeup > > 2) frames out-of-order in first IRQ handler run after wakeup > > > > Thanks a lot! > > > > Best Regards, > > Joakim Zhang > > Hi Joakim, > > > > We are mostly listening for broadcast packages, so we haven't noticed frames > out-of-order :-) Okay, I have discussed with Marc before, this could be possible. You can test with two boards, one receive and another transmit. > > > I have checked this series, it comes out of suspend every time :-) I am not quite understand, could you explain more, this patch cannot fix deadlock issue? Best Regards, Joakim Zhang > /Sean
