Oliver Hartkopp <socketcan@xxxxxxxxxxxx> writes: > On 13/11/2019 11.08, jouni.hogander@xxxxxxxxxx wrote: >> From: Jouni Hogander <jouni.hogander@xxxxxxxxxx> >> >> This patch is fixing memory leak reported by Syzkaller: >> >> BUG: memory leak unreferenced object 0xffff888067f65500 (size 4096): >> comm "syz-executor043", pid 454, jiffies 4294759719 (age 11.930s) >> hex dump (first 32 bytes): >> 73 6c 63 61 6e 30 00 00 00 00 00 00 00 00 00 00 slcan0.......... >> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ >> backtrace: >> [<00000000a06eec0d>] __kmalloc+0x18b/0x2c0 >> [<0000000083306e66>] kvmalloc_node+0x3a/0xc0 >> [<000000006ac27f87>] alloc_netdev_mqs+0x17a/0x1080 >> [<0000000061a996c9>] slcan_open+0x3ae/0x9a0 >> [<000000001226f0f9>] tty_ldisc_open.isra.1+0x76/0xc0 >> [<0000000019289631>] tty_set_ldisc+0x28c/0x5f0 >> [<000000004de5a617>] tty_ioctl+0x48d/0x1590 >> [<00000000daef496f>] do_vfs_ioctl+0x1c7/0x1510 >> [<0000000059068dbc>] ksys_ioctl+0x99/0xb0 >> [<000000009a6eb334>] __x64_sys_ioctl+0x78/0xb0 >> [<0000000053d0332e>] do_syscall_64+0x16f/0x580 >> [<0000000021b83b99>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 >> [<000000008ea75434>] 0xffffffffffffffff >> >> Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx> >> Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> >> Cc: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> >> Signed-off-by: Jouni Hogander <jouni.hogander@xxxxxxxxxx> > > Acked-by: Oliver Hartkopp <socketcan@xxxxxxxxxxxx> > > @Jouni: Can you please take a look into slip_open() in > drivers/net/slip/slip.c ? > > The slcan code is adapted from the original slip.c at this point. I > checked that the same problem can be found in slip.c too. > Ok, I will check it and send patch for that as well. Thank you for pointing this out. BR, Jouni Högander
