On Mon, Oct 21, 2019 at 05:43:36PM +0530, Pankaj Sharma wrote: > The Bosch MCAN hardware (3.1.0 and above) supports interrupt flag to > detect Protocol error in arbitration phase. > > Transmit error statistics is currently not updated from the MCAN driver. > Protocol error in arbitration phase is a TX error and the network > statistics should be updated accordingly. > > The member "tx_error" of "struct net_device_stats" should be incremented > as arbitration is a transmit protocol error. Also "arbitration_lost" of > "struct can_device_stats" should be incremented to report arbitration > lost. > > Signed-off-by: Pankaj Sharma <pankj.sharma@xxxxxxxxxxx> > Signed-off-by: Sriram Dash <sriram.dash@xxxxxxxxxxx> > --- > > changes in v2: > - common m_can_ prefix for is_protocol_err function > - handling stats even if the allocation of the skb fails > - resolving build errors on net-next branch No objections from my side.
