Re: [PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 22/10/2019 19.28, Eric Dumazet wrote
On 10/22/19 9:42 AM, Stephen Hemminger wrote:

Why not fix fq_codel to return the same errors as other qdisc?


I believe the same problem would happen with any qdisc not doing tail drops.

Do we really want to enforce all qdisc to have a common drop strategy ?

CAN has no drop strategy. There is no transport protocol at this point which can handle and compensate drops. CAN is just about PDUs that are sent on a special medium.

And that's what this patch was about.


For example, FQ could implement a strategy dropping the oldest packet in the queue,
which is absolutely not related to the enqueue order.


We have a CAN ID related ematch rule in em_canid.c to be able to configure HTBs, delays or drops. But this is for testing and special use-cases. Silently dropped frames are not expected.

Regards,
Oliver






[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux