Re: [PATCH v3] can: ti_hecc: add fifo overflow error reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Marc,

On 10/11/19 12:39 PM, Marc Kleine-Budde wrote:
> From: Jeroen Hofstee <jhofstee@xxxxxxxxxxxxxxxxx>
>
> When the rx FIFO overflows the ti_hecc would silently drop them since
> the overwrite protection is enabled for all mailboxes. So disable it for
> the lowest priority mailbox and increment the rx_over_errors when
> receive message lost is set. Drop the message itself in that case, since
> it might be partially updated.
>
> Signed-off-by: Jeroen Hofstee <jhofstee@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>


Acked-by: Jeroen Hofstee <jhofstee@xxxxxxxxxxxxxxxxx>

You might want to change the commit message though,
since I doubt it still increments rx_over_errors, at least this
patch no longer does. But afaic you don't need to resend
that.

Regards,

Jeroen





[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux