Hello Marc, On 10/1/19 4:32 PM, Marc Kleine-Budde wrote: > On 9/26/19 10:50 AM, Jeroen Hofstee wrote: >> When the C_CAN interface is closed it is put in power down mode, but >> does not reset the error counters / state. So reset the D_CAN on open, >> so the reported state and the actual state match. >> >> According to [1], the C_CAN module doesn't have the software reset. >> >> [1] http://www.bosch-semiconductors.com/media/ip_modules/pdf_2/c_can_fd8/users_manual_c_can_fd8_r210_1.pdf >> >> Signed-off-by: Jeroen Hofstee <jhofstee@xxxxxxxxxxxxxxxxx> >> --- >> drivers/net/can/c_can/c_can.c | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c >> index 606b7d8ffe13..502a181d02e7 100644 >> --- a/drivers/net/can/c_can/c_can.c >> +++ b/drivers/net/can/c_can/c_can.c >> @@ -52,6 +52,7 @@ >> #define CONTROL_EX_PDR BIT(8) >> >> /* control register */ >> +#define CONTROL_SWR BIT(15) >> #define CONTROL_TEST BIT(7) >> #define CONTROL_CCE BIT(6) >> #define CONTROL_DISABLE_AR BIT(5) >> @@ -569,6 +570,26 @@ static void c_can_configure_msg_objects(struct net_device *dev) >> IF_MCONT_RCV_EOB); >> } >> >> +static int software_reset(struct net_device *dev) > Please add the common prefix "c_can_" to the function Fine with me, I did sent a v2. Regards, Jeroen
