On 8/20/19 1:40 PM, Sean Nyekjaer wrote:
>
>
> On 20/08/2019 13.37, Marc Kleine-Budde wrote:
>> On 8/20/19 9:10 AM, Sean Nyekjaer wrote:
>> [...]
>>>> Feel free to test the patches.
>>
>> Thanks for testing!
>>
>>> While we are at it, could we remove the platform definition section in
>>> the header?
>>
>> Do you mean "struct mcp251x_platform_data"?
>>
>> No, that's not possible, as it's still used in the kernel:
>>
>>> arch/arm/mach-pxa/icontrol.c:72:static struct mcp251x_platform_data mcp251x_info = {
>>> arch/arm/mach-pxa/zeus.c:431:static struct mcp251x_platform_data zeus_mcp2515_pdata = {
>>
>
> What I meant was the comment section in the mcp251x.c file, from line 32
> to 53. :-)
>
> Doesn't that belong in the Documentation section?
Hmm yes, but not
"Documentation/devicetree/bindings/net/can/microchip,mcp251x.txt" as
it's devicetree bindings. So we need another document. What about
removing this section, as no one should create new non-DT boards.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
