Re: [PATCH 1/2] can: c_can: support 64 message objects for D_CAN

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/8/19 2:17 PM, Andrejs Cainikovs wrote:
> D_CAN supports up to 128 message objects, comparing to 32 on C_CAN.
> However, some CPUs with D_CAN controller have their own limits:
> TI AM335x Sitara CPU, for example, supports max of 64 message objects.
> 
> This patch extends max D_CAN message objects up to 64.

Please don't make this a kconfig option.

According to you description this is a HW feature, so please add the max
number of messe objects to "struct c_can_driver_data" and adjust the
drvdata accordingly.

> static const struct of_device_id c_can_of_table[] = {
> 	{ .compatible = "bosch,c_can", .data = &c_can_drvdata },
> 	{ .compatible = "bosch,d_can", .data = &d_can_drvdata },
> 	{ .compatible = "ti,dra7-d_can", .data = &dra7_dcan_drvdata },
> 	{ .compatible = "ti,am3352-d_can", .data = &am3352_dcan_drvdata },
> 	{ .compatible = "ti,am4372-d_can", .data = &am3352_dcan_drvdata },
> 	{ /* sentinel */ },
> };

You probably have to pass it via "struct c_can_priv" so that it's
available in the c_can.c

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux