Hi Kurt, On Mon, Nov 12, 2018 at 11:01:36AM +0100, Oleksij Rempel wrote: > > > On 04.11.18 21:49, Kurt Van Dijck wrote: > > On za, 03 nov 2018 09:24:42 +0100, Oleksij Rempel wrote: > > > On Fri, Nov 02, 2018 at 07:40:48PM +0100, Kurt Van Dijck wrote: > > > > On vr, 02 nov 2018 12:32:19 +0100, Oleksij Rempel wrote: > > > > > > > > > > we will drop this packets soon or later... so drop it better ASAP. > > > > > > > > This is true, unless you monitor all j1939 traffic in 'promiscuous' > > > > mode. I'm not sure if that hasn't been thrown away yet, and is something > > > > designed to be used on a PC anyway. You could extend the check a bit. > > > > > > Same like with ipv4/ipv6/tcp/udp stacks, we do not process unrelated > > > traffic. We capture RAW Ethernet traffic. In this case, in promiscuous mode we > > > should capture RAW CAN traffic, not decoded J1939 traffic. > > > > That means a userspace decoder for j1939 promiscuous spying. > > That makes sense. > > @Kurt, to confirm, you have nothing against this patches? can you please give your Acked-by, if you have nothing against this patches. -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
