On 10/08/2018 09:02 AM, Oleksij Rempel wrote: > 2018.10.08 v2: > Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > resending this patches as pre requirement for j1939 stack. > - added ACKs for already ACKed patches. > > 2017.08.02 v1: > Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > Hello, > > while reviwing and cleaning up the j1939 stack I digged a bit deeper into > af_can and raw implementation. > > The first patch adds a missing error check and will probably go into -stable. > Patches 2-8 change some struct and variable names, making the code more readble, IMHO. > Patch 9 removed the need for struct raw_sock::ifindex from the raw sock, by > using struct sock::sk_bound_dev_if from the generic socket structure. > Patch 10: Checks if can_family is AF_CAN in raw's bind function. > Patch 11: Cleans up the newly integrated CAN net namespace support. > > Patches 13-14: Where to put the per device protocol specific memory? > af_can allocated it's memory during a netdev_notifier call, life cycle proves > to be rather complicated (see remove_on_zero_entries, etc...), adding the > j1939 memory makes it even more compilcated. So I decided to allocate the > memory during the allocation if net_device. And this seems to work. More > details in the individual patches. > > This series applies to net-next/master, but should work on any recent > kernel. > Please review, test and comment. Added to linux-can-next/j1939, as this will be the base for the j1939 stack. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
