> -----Original Message----- > From: Marc Kleine-Budde [mailto:mkl@xxxxxxxxxxxxxx] > Sent: Wednesday, August 1, 2018 3:00 PM > To: Pankaj Bansal <pankaj.bansal@xxxxxxx>; linux-can@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v3 7/7] net: can: flexcan: use CAN FD frames for Tx/Rx > > On 08/01/2018 04:06 PM, Pankaj Bansal wrote: > > Use can FD frames for Tx/Rx operations. This would be needed in > > upcoming SOC LX2160A, which supports CAN FD protocol > > > > Signed-off-by: Pankaj Bansal <pankaj.bansal@xxxxxxx> > > I think the code can be simplified if you introduce a union for can_fram and > canfd_frame. Can you be more specific in which structure/function? I was thinking of passing a skb to mailbox_read function instead of canfd_frame or can_frame. That way the code in rx_overload.c would become cleaner. Also for overflow cases (when we can't allocate skb for mailbox_read) I think a reserved skb should be placed in rx_overload structure when rx_overload is initialized. As for xmit and mailbox_read functions in flexcan.c, I think these are fine. > > More review on Friday. I will wait for your comments, before I send any new version of these patches. > > Marc > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | ��.n��������+%������w��{.n�����{����* jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
