On 07/31/2018 09:34 AM, Pankaj Bansal wrote: >> BTW: please update the "FLEXCAN hardware feature flags" table in the >> driver, add a CAN-FD column, too. > > Ok. I have a question though. Should we still call these "QUIRKS"? > It gives an impression that there is something wrong with the SOC which has this "QUIRK". feel free to rename quirk to feature :) >> This does look quite complex and could result in ugly code. First thing is to >> have a function that converts from mailbox number to mailbox address. > Agreed. I will send the V2 of patches with these changes. Also I > will send a RFC patch for CAN FD protocol changes that I am still > working on (NOT ready yet). It should help in understanding the > context of these patches and how I plan to use these changes in FD > mode. Sounds good. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Attachment:
signature.asc
Description: OpenPGP digital signature
