Hello Martin, all, Am 14.06.2018 um 07:19 schrieb Martin Sperl: > >> On 12.06.2018, at 16:38, Wolfgang Grandegger <wg@xxxxxxxxxxxxxx> wrote: >> >> Hello Martin, >> >> this driver is huge... more than 4300 lines of code. That's maybe one >> reason why it has not yet been reviewed. The driver includes a debugfs >> interface and is also very verbose in general. I'm not sure if the >> debugging code is really useful for the end user, but well, debugfs is >> exactly for that purpose. What about splitting up the driver in a >> subdirectory "mcp2517fd" into core, spi, debugfs, etc. Other opinions? > > Splitting does unfortunately strip the compiler from the opportunity to > Automatically inline code. > > What I was thinking is maybe to split up the patch into: > * basic functionality > * debugfs > * optimization code > * gpio lib related (already separated) > * documentation comments > > Would that be helpful? I recently sent a review for: [PATCH V3 2/3] can: mcp25xxfd: Add Microchip mcp25xxfd CAN FD driver but it did not show up on the linux-can ml. I also cannot find the original patch. Patch 2/3 from your V3 and V4 series is missing in the archive. Is there a size limitation? Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe linux-can" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
