On Wed, Nov 23, 2022 at 2:48 PM David Howells <dhowells@xxxxxxxxxx> wrote: > > I've also got rid of the bit clearances > from the network filesystem evict_inode functions as they doesn't seem to > be necessary. Well, the patches look superficially cleaner to me, at least. That "doesn't seem to be necessary" makes me a bit worried, and I'd have liked to see a more clear-cut "clearing it isn't necessary because X", but I _assume_ it's not necessary simply because the 'struct address_space" is released and never re-used. But making the lifetime of that bit explicit might just be a good idea. Linus -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs