On 7/25/22 06:57, William Breathitt Gray wrote: > On Mon, Jul 25, 2022 at 06:52:15AM -0700, Joe Perches wrote: >> On Fri, 2022-07-22 at 07:45 +0800, Baoquan He wrote: >>> On 07/21/22 at 11:40am, Randy Dunlap wrote: >>>> On 7/21/22 11:36, Jonathan Corbet wrote: >>>>> "Slark Xiao" <slark_xiao@xxxxxxx> writes: >>>>>> May I know the maintainer of one subsystem could merge the changes >>>>>> contains lots of subsystem? I also know this could be filtered by >>>>>> grep and sed command, but that patch would have dozens of maintainers >>>>>> and reviewers. >>>>> >>>>> Certainly I don't think I can merge a patch touching 166 files across >>>>> the tree. This will need to be broken down by subsystem, and you may >>>>> well find that there are some maintainers who don't want to deal with >>>>> this type of minor fix. >>>> >>>> We have also seen cases where "the the" should be replaced by "then the" >>>> or some other pair of words, so some of these changes could fall into >>>> that category. >>> >>> It's possible. I searched in Documentation and went through each place, >>> seems no typo of "then the". Below patch should clean up all the 'the the' >>> typo under Documentation. >> [] >>> The fix is done with below command: >>> sed -i "s/the the /the /g" `git grep -l "the the " Documentation` >> >> This command misses entries at EOL: >> >> Documentation/trace/histogram.rst: Here's an example where we use a compound key composed of the the >> >> Perhaps a better conversion would be 's/\bthe the\b/the/g' > > It would be good to check for instances that cross newlines as well; > i.e. "the" at the end of a line followed by "the" at the start of the > next line. However, this would require some thought to properly account > for comment blocks ("*") and other similar prefixes that should be > ignored. Yeah, the script that I posted last year (?) does that, but it's noisy -- results need to be hand-checked. It's not clear how people are finding these repeated words, other than something like $ grep "the the" * -- ~Randy -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs