On Thu, Jul 07, 2022 at 02:21:45PM +0100, David Howells wrote: > - struct folio *folio, void **_fsdata); > + struct folio **_folio, void **_fsdata); The usual convention is that _foo means "Don't touch". This should probably be named "foliop" (ie pointer to a thing that would normally be called folio). -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs