On Wed, 2022-03-09 at 15:49 +0000, David Howells wrote: > Jeff Layton <jlayton@xxxxxxxxxx> wrote: > > > Should you undef EM and E_ here after creating these? > > Maybe. So far it hasn't mattered... > I wasn't suggesting there was a bug there, more just a code hygiene thing. With macro names as generic as that (especially), it'd probably be good to undef them once you're done. -- Jeff Layton <jlayton@xxxxxxxxxx> -- Linux-cachefs mailing list Linux-cachefs@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/linux-cachefs